[alsa-devel] [PATCH] add new Fermi 5xx codec IDs to snd-hda

[Richard Samson]

Le lundi 28 février 2011 à 19:09 +0100, Takashi Iwai a écrit :
> At Mon, 28 Feb 2011 18:56:20 +0100,
> samson.richard at gmail.com wrote:
> > 
> > Hello,
> > 
> > Thank you for your replies.
> > 
> > As Stephen Warren said, a patch with full support of 5xx cards will be
> > more useful.
> > I'll be able to write a new patch but I don't have the knowledge to
> > get other IDs.
> 
> OK, Stephen, could you prepare the patch including all missing IDs?
> 
> 
> thanks,
> 
> Takashi
> 

Hello,

I wrote an new patch with three new codec IDs for Nvidia Fermi cards.
I attended to use existing IDs and online technical specifications to
get two others cards :
- Nvidia GeForce GTX 470 : id = 0x10de0015
- Nvidia GeForce GTX 560 Ti : id = 0x10de0016 (works fine)
- Nvidia GeForce GTX 570 : id = 0x10de0017

Stephen, could you confirm these new IDs are correct ?

This patch applies on 2.6.38-rc6 and trunk.

Signed-off-by: Richard Samson <samson.richard at gmail.com>

diff -up sound/pci/hda/patch_hdmi.c{.orig,} >
~/snd-codec-hda_patch-hdmi_Nvidia_5xx.patch
--- sound/pci/hda/patch_hdmi.c.orig     2011-03-01 14:15:07.380860984
+0100
+++ sound/pci/hda/patch_hdmi.c  2011-03-01 15:44:16.836444133 +0100
@@ -1634,6 +1634,9 @@ static struct hda_codec_preset snd_hda_p
 { .id = 0x10de0012, .name = "GPU 12 HDMI/DP",  .patch =
patch_nvhdmi_8ch_89 },
 { .id = 0x10de0013, .name = "GPU 13 HDMI/DP",  .patch =
patch_nvhdmi_8ch_89 },
 { .id = 0x10de0014, .name = "GPU 14 HDMI/DP",  .patch =
patch_nvhdmi_8ch_89 },
+{ .id = 0x10de0015, .name = "GPU 15 HDMI/DP",   .patch =
patch_nvhdmi_8ch_89 },
+{ .id = 0x10de0016, .name = "GPU 16 HDMI/DP",   .patch =
patch_nvhdmi_8ch_89 },
+{ .id = 0x10de0017, .name = "GPU 17 HDMI/DP",   .patch =
patch_nvhdmi_8ch_89 },
 { .id = 0x10de0018, .name = "GPU 18 HDMI/DP",  .patch =
patch_nvhdmi_8ch_89 },
 { .id = 0x10de0019, .name = "GPU 19 HDMI/DP",  .patch =
patch_nvhdmi_8ch_89 },
 { .id = 0x10de001a, .name = "GPU 1a HDMI/DP",  .patch =
patch_nvhdmi_8ch_89 },
@@ -1676,6 +1679,9 @@ MODULE_ALIAS("snd-hda-codec-id:10de0011"
 MODULE_ALIAS("snd-hda-codec-id:10de0012");
 MODULE_ALIAS("snd-hda-codec-id:10de0013");
 MODULE_ALIAS("snd-hda-codec-id:10de0014");
+MODULE_ALIAS("snd-hda-codec-id:10de0015");
+MODULE_ALIAS("snd-hda-codec-id:10de0016");
+MODULE_ALIAS("snd-hda-codec-id:10de0017");
 MODULE_ALIAS("snd-hda-codec-id:10de0018");
 MODULE_ALIAS("snd-hda-codec-id:10de0019");
 MODULE_ALIAS("snd-hda-codec-id:10de001a");

Thanks.
Richard Samson

> > 
> > Richard Samson
> > 
> > 2011/2/28 Takashi Iwai <tiwai at suse.de>:
> > > At Mon, 28 Feb 2011 09:13:29 -0800,
> > > Stephen Warren wrote:
> > >>
> > >> Richard Samson wrote at Sunday, February 27, 2011 6:11 PM:
> > >> > ...
> > >> > I added a new entry in patch_hdmi.c to get sound working on my own 560
> > >> > Ti card :
> > >> >
> > >> > --- patch_hdmi.c        2011-02-15 22:29:51.000000000 +0100
> > >> > +++ patch_hdmi_GTX-560Ti.c      2011-02-27 23:52:56.984613414 +0100
> > >> ...
> > >> > patch_nvhdmi_8ch_89 },
> > >> >  { .id = 0x10de0014, .name = "GPU 14 HDMI/DP",  .patch =
> > >> > patch_nvhdmi_8ch_89 },
> > >> > +{ .id = 0x10de0016, .name = "GPU 16 HDMI/DP",   .patch =
> > >> > patch_nvhdmi_8ch_89 },
> > >> >  { .id = 0x10de0018, .name = "GPU 18 HDMI/DP",  .patch =
> > >> ...
> > >>
> > >> Acked-By: Stephen Warren <swarren at nvidia.com>
> > >>
> > >> Hmm. When I submitted that last patch, I think I looked at the wrong branch
> > >> of our Windows drivers, and hence missed a couple IDs, and added a couple of
> > >> IDs that won't be used. Once this is merged, I'll follow up with another
> > >> patch to fix the other issues (or let me know if you just want me to provide
> > >> a single patch with everything in it, Takashi).
> > >
> > > I don't mind in either way as long as it's a simple patch.
> > > As I already asked Richard for re-submitting with his sign-off,
> > > we can wait for a while.
> > >
> > > BTW, this kind of id addition patch can be still merged in 2.6.38
> > > if the chips listed there are real ones.
> > >
> > >
> > > thanks,
> > >
> > > Takashi
> > >
> >