[alsa-devel] [PATCH] ASoC: Fix Blackfin I2S _pointer() implementation return in bounds values

[Mark Brown]

On Thu, Jun 23, 2011 at 09:10:31PM +0200, Lars-Peter Clausen wrote:
> On 06/23/2011 09:02 PM, Mark Brown wrote:
> > [...]
> > +	if (diff == snd_pcm_lib_buffer_bytes(substream))
> > +		diff = 0;
> > +	}

> stray closing bracket

Hrm, so there is.  Fixed locally, I guess there's no point in reposting
just for that.

> > +	frames = bytes_to_frames(substream->runtime, diff);
> > +
> >  	return frames;

> Could be 'return bytes_to_frames(substream->runtime, diff);' directly

Does no harm either way, though.  I don't always find doing the return
directly quite so parsable, but I think here I wrote it this way because
it makes the diff a bit more obvious.