[alsa-devel] [PATCH] ALSA: ASoC: add STA32X codec driver

[Daniel Mack]

I really hate to bother you, but can we merge this before it gets lost?


Daniel

On Mon, Jun 20, 2011 at 8:07 AM, Daniel Mack <zonque at gmail.com> wrote:
> On Fri, Jun 17, 2011 at 11:45 AM, Mark Brown
> <broonie at opensource.wolfsonmicro.com> wrote:
>> On Thu, Jun 16, 2011 at 02:07:23PM +0200, Daniel Mack wrote:
>>
>> Looks very good, a few small nits, if Liam's OK I guess we could fix
>> these incrementally:
>>
>>> +#define DEBUG
>>
>> This shouldn't be in the submission.
>>
>>> +SOC_SINGLE_TLV("Master Volume", STA32X_MVOL, 0, 0xff, 1, mvol_tlv),
>>> +SOC_SINGLE("Master Playback Switch", STA32X_MMUTE, 0, 1, 1),
>>> +SOC_SINGLE("Ch1 Playback Switch", STA32X_MMUTE, 1, 1, 1),
>>> +SOC_SINGLE("Ch2 Playback Switch", STA32X_MMUTE, 2, 1, 1),
>>> +SOC_SINGLE("Ch3 Playback Switch", STA32X_MMUTE, 3, 1, 1),
>>> +SOC_SINGLE_TLV("Ch1 Volume", STA32X_C1VOL, 0, 0xff, 1, chvol_tlv),
>>> +SOC_SINGLE_TLV("Ch2 Volume", STA32X_C2VOL, 0, 0xff, 1, chvol_tlv),
>>> +SOC_SINGLE_TLV("Ch3 Volume", STA32X_C3VOL, 0, 0xff, 1, chvol_tlv),
>>
>> The "Playback" should be consistently either present or not present in
>> both volume and mute controls so UIs can match them up easily.
>>
>
> I've sent a fixed version of this patch just after you mentioned these
> issues. Hope it's all good now.
>
> Daniel
>