[alsa-devel] [PATCH] ASoC: codecs: Max98095: Fix logging of hardware revision.

Taylor Hutt thutt at google.com
Tue Jun 21 05:22:32 CEST 2011

On Mon, Jun 20, 2011 at 5:23 PM, Mark Brown <
broonie at opensource.wolfsonmicro.com> wrote:

> On Mon, Jun 20, 2011 at 11:54:32AM -0700, Taylor Hutt wrote:
> > The base hardware revision of the Maxim 98095 part is 0x40; the code
> > which outputs the revision of the hardware has been updated to
> > properly use uppercase alphabetic values for the revision numbers.
> Are you sure that this is true for all devices that might be supported
> by the driver (I'm guessing there may be other variants)?  There's often
> a drift between silicon and package revisions which gets papered over by
> datasheets and ignored by drivers.
Got this information from Peter, as he notes below.  I'm just the messenger
on this particular change; I'm merely trying to upstream
the information he provided me.  Whatever you folks want, I'll be happy to

> > Also, the use of a constant for the length 'max98095_dai' has been
> > replaced with ARRAY_SIZE().
> Don't include a series of random unrelated changes in a single patch,
> split them up into separate patches.  This makes review much easier if
> nothing else.  There's no overlap at all between this change and the one
> above.  The change is sensible.

Ok, fine.  Seemed trivial enough and didn't seem like the code churn for
another patch was warranted.
But, ok.

> >       ret = snd_soc_read(codec, M98095_0FF_REV_ID);
> >       if (ret < 0) {
> > -             dev_err(codec->dev, "Failed to read device revision: %d\n",
> > +             dev_err(codec->dev, "Failure reading hardware revision:
> %d\n",
> >                       ret);
> You've also got this again unrelated change which isn't mentioned in the
> changelog at all.

This is part of the change for the hardware revision, and it seems pretty
clear that they're related to me.  The text of the two output messages are
now more aligned, and they are both related to reporting the hardware

There is no better hors d'oeuvres than bacon wrapped dates.

More information about the Alsa-devel mailing list