[alsa-devel] [PATCH] ASoC: codecs: Max98095: Fix logging of hardware revision.

Mark Brown broonie at opensource.wolfsonmicro.com
Tue Jun 21 02:23:39 CEST 2011

On Mon, Jun 20, 2011 at 11:54:32AM -0700, Taylor Hutt wrote:
> The base hardware revision of the Maxim 98095 part is 0x40; the code
> which outputs the revision of the hardware has been updated to
> properly use uppercase alphabetic values for the revision numbers.

Are you sure that this is true for all devices that might be supported
by the driver (I'm guessing there may be other variants)?  There's often
a drift between silicon and package revisions which gets papered over by
datasheets and ignored by drivers.

> Also, the use of a constant for the length 'max98095_dai' has been
> replaced with ARRAY_SIZE().

Don't include a series of random unrelated changes in a single patch,
split them up into separate patches.  This makes review much easier if
nothing else.  There's no overlap at all between this change and the one
above.  The change is sensible.

>  	ret = snd_soc_read(codec, M98095_0FF_REV_ID);
>  	if (ret < 0) {
> -		dev_err(codec->dev, "Failed to read device revision: %d\n",
> +		dev_err(codec->dev, "Failure reading hardware revision: %d\n",
>  			ret);

You've also got this again unrelated change which isn't mentioned in the
changelog at all.

More information about the Alsa-devel mailing list