[alsa-devel] [patch] ASoC: adau1701: signedness bug in adau1701_write()

Mark Brown broonie at opensource.wolfsonmicro.com
Mon Jun 20 19:49:16 CEST 2011


On Mon, Jun 20, 2011 at 10:11:25AM +0300, Dan Carpenter wrote:
> "ret" is supposed to be signed here.  The current code will only
> return -EIO on error, instead of a more appropriate error code such
> as -EAGAIN etc.

That changelog is not accurate, if nothing else the code will return
-EINVAL if it can't figure out a length for a register.  However, the
change itself is good so applied, thanks.


More information about the Alsa-devel mailing list