[alsa-devel] [PATCH 1/2] ALSA: ASoC: add STA32X codec driver

Daniel Mack zonque at gmail.com
Thu Jun 16 10:53:41 CEST 2011


On Thu, Jun 16, 2011 at 10:49 AM, Liam Girdwood <lrg at ti.com> wrote:
> On 16/06/11 09:19, Daniel Mack wrote:
>> From: Johannes Stezenbach <js at sig21.net>
>>
>> Signed-off-by: Johannes Stezenbach <js at sig21.net>
>> [zonque at gmail.com: transform to new ASoC structure]
>> ---
>>  sound/soc/codecs/Kconfig  |    4 +
>>  sound/soc/codecs/Makefile |    2 +
>>  sound/soc/codecs/sta32x.c |  796 +++++++++++++++++++++++++++++++++++++++++++++
>>  sound/soc/codecs/sta32x.h |  210 ++++++++++++
>>  4 files changed, 1012 insertions(+), 0 deletions(-)
>>  create mode 100644 sound/soc/codecs/sta32x.c
>>  create mode 100644 sound/soc/codecs/sta32x.h
>
> Is this intended for review only or upstream as there is a lot of code behind #if 0 and a lots of FIXMEs ?

It is sure intended for upstream. I'll fix the TLV issues and remove
the #if0. The code runs fine on a board here, and the FIXMEs are just
markers for future improvements :)

As I said in my first email, the code was not written by me. I just
care to bring it mainline.

Thanks for the reviews, everyone.

Daniel


More information about the Alsa-devel mailing list