[alsa-devel] Creative X-Fi Titanium HD ctxfi bugs 5378 5218 4868

[Harry Butterworth]

Great.  Creative got back to me today with a proposed solution for the
PLL initialization.  I'll follow up with another patch in the next
week probably.

Harry

On 14 June 2011 13:38, Takashi Iwai <tiwai at suse.de> wrote:
> At Sun, 12 Jun 2011 18:48:27 +0200,
> Takashi Iwai wrote:
>>
>> At Sat, 11 Jun 2011 18:25:36 +0800,
>> Harry Butterworth wrote:
>> >
>> > Hi,
>> >
>> >     I have redone the patch against today's git repositories.
>> > Creative have not yet got back to me about the PLL initialization.
>> > Perhaps we can fix that later.
>> >
>> >     I have only put the PCI ID in the pci_ids_compat.h.in file.  Is it
>> > going to be necessary to add the PCI device ID somewhere in the kernel
>> > tree to avoid breaking the kernel build?
>>
>> Yes, include/linux/pci_ids.h is the place to change.
>> But I can fix it by myself, too.
>>
>> >
>> > > A few comment about the patch:
>> > >
>> > > - Instead of adding have_dedicated_mic and have_output_switch
>> > >  callbacks in every place, I'd put some bit flags indicating the
>> > >  capabilities, and set at the initialization appropriately.
>> >
>> > I had a go at this in the patch 0002-ALSA...
>> >
>> > > - A few easy coding-style issues; run scripts/checkpatch.pl and fix
>> > >  the errors appropriately.
>> >
>> > checkpatch now reports no errors.
>> >
>> > I've only tested these changes with my Titanium HD card.  I don't have
>> > any of the other X-Fi cards so I couldn't do any regression testing.
>> >
>> > If there's anything else I need to do, please let me know.
>>
>> I'm going to check patches in a more detail tomorrow.
>
> Now both patches were applied to sound git tree.
> Just minor fixes were applied in addition (coding-style issues in the
> second patch and added the definition in include/linux/pci_ids.h in
> the first patch).
>
>
> thanks,
>
> Takashi
>