[alsa-devel] [Device-drivers-devel] [PATCH 1/3] ASoC: Add ADAU1701 codec driver

[Mike Frysinger]

On Fri, Jun 10, 2011 at 14:22, Lars-Peter Clausen wrote:
> On 06/10/2011 08:15 PM, Mike Frysinger wrote:
>> On Fri, Jun 10, 2011 at 14:08, Mike Frysinger wrote:
>>> On Fri, Jun 10, 2011 at 13:57, Lars-Peter Clausen wrote:
>>>> On 06/10/2011 07:43 PM, Mike Frysinger wrote:
>>>>> On Fri, Jun 10, 2011 at 13:18, Lars-Peter Clausen wrote:
>>>>>> +MODULE_AUTHOR("Lars-Peter Clausen <lars at metafoo.de>");
>>>>>
>>>>> did you actually rewrite this thing from scratch ?  seems like you
>>>>> should keep Cliff as the author in git/MODULE_AUTHOR, and then add
>>>>> your name to the s-o-b list and this macro.
>>>>
>>>> Not from scratch, but I guess except for the register definitions and the
>>>> copyright header not much of the original driver is left:
>>>> sound/soc/codecs/adau1701.c |  662 ++++++++++++++++++++++++-------------------
>>>>  1 files changed, 371 insertions(+), 291 deletions(-)
>>>
>>> based purely on LoC, Cliff wrote 467, so you took that and punted 291
>>> (62%) and then added 371.  that leaves the final file with 32% Cliff
>>> and 68% you.
>>>
>>> however, some of that was register renaming and shuffling between the
>>> adau1701.c and adau1701.h, and it's easier to start with a base and
>>> clean up than from scratch.
>>>
>>> so i'm definitely not comfortable dropping Cliff's completely from the
>>> file and the log (which means he needs to be readded and made sure to
>>> be retained in all the other ADAU drivers going forward), and i'm not
>>> entirely sold about changing of the Author field in the git commit.
>>>
>>> don't get me wrong ... i'm not a fanboi of Cliff or something, i just
>>> think credit is due to him for his work.
>
> You have both the orignal driver and the new driver, so you can do the diff for
> yourself.

i did do that already which is why i commented on the register renaming

> But of course if you want to see his name as the author, you get his name as
> the author.

if you feel strongly about it, then you may keep your name there

>> to be clear, i'm like 50/50 on the git author field.  maybe someone
>> else here has an opinion, or you feel strongly enough that your
>> rewrite supersedes his seeding work.  but please send a v2 with
>> updated source/changelog with his name in it.
>
> His name is already in the copyright header.

sorry, i missed that the first time.  but also list him in
MODULE_AUTHOR (i'll leave order preference to you).
-mike