[alsa-devel] [PATCH] ASoC: omap-mcbsp: Do not attempt to change DAI sysclk if stream is active

Mark Brown broonie at opensource.wolfsonmicro.com
Fri Jun 10 13:35:30 CEST 2011

On Fri, Jun 10, 2011 at 02:28:55PM +0300, Jarkko Nikula wrote:

> +	if (mcbsp_data->active)
> +		return 0;
> +

Shouldn't we be returning -EBUSY or something here so the caller knows
we didn't do what it asked (after checking to make sure it's not just
trying to set the existing configuration)?  Otherwise it might get
surprised, assume the new configuration and just move the bug elsewhere.

More information about the Alsa-devel mailing list