[alsa-devel] [PATCH 1/2] ASoC: p1022ds: fix incorrect referencing of device tree properties

[Steve Calfee]

On 06/08/11 13:02, Timur Tabi wrote:
> Device tree integer properties are encoded in big-endian format, but some of
> the Freescale ASoC drivers were assuming that the host is in big-endian format
> as well.  Although this is true, it's better to use endian-safe accessors.

Hi Timur,

Can this be true?

I would assume a software constructed data structure would be in
host-endian mode. The only reason to be concerned with endianness is if
you are transmitting binary over some communications medium, or sending
something to hardware (which in rare circumstances may not be host-endian).

Throwing in macros that will always be discarded (if this host is
bigendian) seems unnecessary.

Regards, Steve

> 
> Also add a check for a failed ioremap() call in the SSI driver.
An urelated change should probably be in a new patch.
> 
> Signed-off-by: Timur Tabi <timur at freescale.com>