[alsa-devel] [PATCH] wm8940: remove unecessary if statement
lrg at ti.com
Mon Jun 6 11:51:58 CEST 2011
On 06/06/11 10:31, Jonathan Cameron wrote:
> On 06/06/11 01:47, Greg Dietsche wrote:
>> the code always returns ret regardless, so if(ret) check is unecessary.
> Good point, though please spell check your commit messages.
> unecessary -> unnecessary
> Also if you want to do this sort of cleanup, please also fix the
> equivalent in wm8940_resume and wm8940_add_widgets. Ack is for
> what is here, plus those if you do them.
> Just as an aside, there is no earthly point in cc'ing lkml for a
> simple cleanup like this. Just adds to already huge amount of noise!
>> Signed-off-by: Greg Dietsche <Gregory.Dietsche at cuw.edu>
> Acked-by: Jonathan Cameron <jic23 at cam.ac.uk>
Acked-by: Liam Girdwood <lrg at ti.com>
More information about the Alsa-devel