[alsa-devel] [PATCH] gpio: add GPIOF_ values regardless on kconfig settings
grant.likely at secretlab.ca
Fri Jun 3 19:04:52 CEST 2011
On Fri, May 27, 2011 at 2:12 PM, Grant Likely <grant.likely at secretlab.ca> wrote:
> On Fri, May 27, 2011 at 10:46:57AM -0700, Randy Dunlap wrote:
>> From: Randy Dunlap <randy.dunlap at oracle.com>
>> Make GPIOF_ defined values available even when GPIOLIB nor GENERIC_GPIO
>> is enabled by moving them to <linux/gpio.h>.
>> Signed-off-by: Randy Dunlap <randy.dunlap at oracle.com>
> Applied, thanks.
I ended up not pushing this one to Linus. Turns out it causes other
breakage on other platforms that don't include include/linux/gpio.h.
Since I don't have confidence that I'll be able to find all the
offenders, I'm dropping it. I recommend making any drivers that are
breaking on these symbols depend on GPIOLIB. Platforms not using
gpiolib are strongly discouraged now anyways, and there only a handful
of files in drivers/ that reference GPIOF_*.
More information about the Alsa-devel