[alsa-devel] [PATCH 3/8] MFD: twl4030-audio: Rename platform data

Peter Ujfalusi peter.ujfalusi at ti.com
Wed Jun 1 14:54:52 CEST 2011

On Wednesday 01 June 2011 15:07:54 Tony Lindgren wrote:
> Can you please take a look at creating arch/arm/mach-omap2/i2c-twl.c or
> something in common-board-devices.c to get rid of the cut and paste
> duplication in every board-*.c file?

Yes, it would make sense, since most of the board has similar configuration, 
and we have lots of duplicated code around.
> Maybe you could have a generic twl_init function that allows overriding
> things like keypad with board specific configuration?

We might need also support for overriding other configurations 
(audio/codec/vibra for sure needs that).

I'll take a look, but I think it is not going to be part of v2 of this series.


More information about the Alsa-devel mailing list