[alsa-devel] [PATCH] ALSA: Make snd_pcm_debug_name usable outside pcm_lib

Eliot Blennerhassett eblennerhassett at audioscience.com
Sat Jul 23 01:59:23 CEST 2011

On 22/07/11 22:22, Takashi Iwai wrote:
> At Fri, 22 Jul 2011 22:05:26 +1200,
> linux at audioscience.com wrote:
>> From: Eliot Blennerhassett <eblennerhassett at audioscience.com>
>> Formatting a PCM name is useful for module debug too.
>> Add snd_prefix when making function public.
>> Signed-off-by: Eliot Blennerhassett <eblennerhassett at audioscience.com>
> It'd need EXPORT_SYMBOL*() in addition.
> Or, this can be defined as an inline function.
> It's just a call of snprintf() with the passed arguments, after all.

Hmm. A side-effect of doing it this way is to make pcm.h depend on
core.h, (for substream->pcm->card->number) and there are some files that
include pcm.h but not core.h. E.g. pcsp_lib.c, ctvmem.c, oxygen_lib.c
(and quite a few other possible candidate)

Fix these, or go with the original non-inline version?


More information about the Alsa-devel mailing list