[alsa-devel] [RESEND][PATCH v5 4/4] ASoC: SAMSUNG: Add I2S0 internal dma driver

[Jassi Brar]

On Mon, Jul 18, 2011 at 2:47 PM, Sangbeom Kim <sbkim73 at samsung.com> wrote:
> Hi,
> On Mon, July 18, 2011 at 4:38 PM, Jassi Brar wrote:
>> On Wed, Jul 13, 2011 at 10:29 AM, Sangbeom Kim <sbkim73 at samsung.com> wrote:
>> > I2S in Exynos4 and S5PC110(S5PV210) has a internal dma.
>> > It can be used low power audio mode and 2nd channel transfer.
>> > This patch can support idma.
>> >
>> > Signed-off-by: Sangbeom Kim <sbkim73 at samsung.com>
>> > ---
>> > V2: change idma_new by new pcm_new api
>> >    add handling different idma address
>> >    as jassi comments, Modify the idma driver
>> >
>> > V3: merge idma_reg_int and idma_addr_init
>> >
>> > V4: move idma setting in i2s.c to idma_hw_params in idma.c
>> >    move idma_reg_addr_init calling
>> >    modify idma address handling error
>> >    modify module information
>> >    delete useless dev_dbg
>> >
>> > V5: delete redundant error print and check routine
>> >    modify irq handler as jassi comment
>> >    fix the indent error
>> >    modify period_bytes_max value to set half size of max buffer
>>
>> Perhaps you forgot to mention the reason for resend ?
> Sorry, I changed MAX_IDMA_BUFFER value (128KB)
> Because I used wrong MAX_IDMA_BUFFER value.
No, we should not set period_bytes_max to half the buffer.
That will leave no scope for even customized applications to
get max possible power savings.