[alsa-devel] [PATCH V2 06/10] ARM: mxs: add saif device
dongas86 at gmail.com
Fri Jul 15 17:02:36 CEST 2011
2011/7/15 Wolfram Sang <w.sang at pengutronix.de>:
>> +#define DIGCTRL_BASE_ADDR MX28_IO_ADDRESS(MX28_DIGCTL_BASE_ADDR)
> Hmm, maybe define a function mx28_set_saif_clkmux(val)?
>> + mx28_add_saif(0);
>> + mx28_add_saif(1);
>> + /*set the saif clk mux, both saif0/saif1 use saif0 clk*/
>> + __raw_writel(0x2 << 10, DIGCTRL_BASE_ADDR);
> You might overwrite previous settings here. The hardcoded numbers need
> defines, too.
I'm originally going to do that when implement record because this
setting may affect both
machine driver and saif driver on recording.
Since currently we only implement playback, so i just hardcode it.
Do you think if that's ok?
Or i need to do it now?
More information about the Alsa-devel