[alsa-devel] [PATCH] sound, hda_eld: suspicious sizeof() in call to snd_print_pcm_bits()

Wu Fengguang wfg at linux.intel.com
Sat Jan 29 11:46:33 CET 2011


On Sat, Jan 29, 2011 at 01:40:04AM +0100, Jesper Juhl wrote:

>  	if (a->format == AUDIO_CODING_TYPE_LPCM)
> -		snd_print_pcm_bits(a->sample_bits, buf2 + 8, sizeof(buf2 - 8));
> +		snd_print_pcm_bits(a->sample_bits, buf2 + 8, sizeof(buf2) - 8);

Good catch!

Reviewed-by: Wu Fengguang <fengguang.wu at intel.com>


More information about the Alsa-devel mailing list