[alsa-devel] [PATCH] ASoC: Fix typo in snd_soc_dapm_put_volsw

Stephen Warren swarren at nvidia.com
Fri Jan 28 17:16:27 CET 2011

Mark Brown wrote at: Friday, January 28, 2011 6:21 AM:
> On Fri, Jan 28, 2011 at 01:12:43PM +0000, Mark Brown wrote:
> > snd_soc_dapm_put_volsw() has variables for both the unshifted and
> > shifted mask for updates commit 97404f (ASoC: Do DAPM control updates in
> > the middle of DAPM sequences) got confused between the two of these.
> > Since there's no need to keep a copy of the unshifted mask fix this and
> > simplify the code by using only one mask variable.
> Applied with the changelog rewritten to the above - good spot, thanks!

Yeah sorry, the original patch was:

-                update.mask = mask;
+                update.mask = val_mask;

But once that was done, there was an unused variable which I ended up
removing, but completely forgot that I should rewrite the commit
description. I realized this last night and was going to correct it



More information about the Alsa-devel mailing list