[alsa-devel] [PATCH] ASoC: Fix typo in snd_soc_dapm_put_volsw

Mark Brown broonie at opensource.wolfsonmicro.com
Fri Jan 28 14:12:43 CET 2011

On Thu, Jan 27, 2011 at 02:54:05PM -0700, Stephen Warren wrote:
> This fixes a regression introduced by:
> 97404f2e0386ac147cec00fc5d89ea475b04bd78
> ASoC: Do DAPM control updates in the middle of DAPM sequences

This would be *much* easier to review if you'd mentioned what the issue
you're fixing is...  I think the changelog should be something along the
lines of:

snd_soc_dapm_put_volsw() has variables for both the unshifted and
shifted mask for updates commit 97404f (ASoC: Do DAPM control updates in
the middle of DAPM sequences) got confused between the two of these.
Since there's no need to keep a copy of the unshifted mask fix this and
simplify the code by using only one mask variable.

More information about the Alsa-devel mailing list