[alsa-devel] [PATCH 4/4] ASoC: Convert bunch of codecs to use soc-core interconnect registration

Peter Ujfalusi peter.ujfalusi at nokia.com
Thu Jan 27 07:57:09 CET 2011

On 01/26/11 13:58, ext Jarkko Nikula wrote:
> These codec drivers have only single interconnect map so these can be
> switched to use soc-core based interconnect registration.
> This simplifies those codecs that check the return value of
> snd_soc_dapm_add_routes and adds a failure path to those that don't.

I might be missing something, but the only benefit of the 3+4 patch is
actually the failure check for the snd_soc_dapm_add_routes, which was
not done for most of the codecs, but now it is done in the core.
On the other hand, now we always have one check for the
codec->driver->route in soc_probe_codec.
I don't see how these actually simplifies the codec drivers.
We had a single snd_soc_dapm_add_routes call before the patches, now we
have two fields to fill in snd_soc_codec_driver...


More information about the Alsa-devel mailing list