[alsa-devel] [PATCH 3/4] ASoC: mid-x86: Add support for capture in machine driver

[Mark Brown]

On Wed, Jan 19, 2011 at 09:59:59PM +0530, Koul, Vinod wrote:

> > > +	/* we are using DMICs here so configure how the clock and out pin is set
> > */
> > > +	snd_soc_write(codec, SN95031_DMICBUF0123, 0x85);
> > > +	snd_soc_write(codec, SN95031_DMICBUF45, 0x02);
> > > +	snd_soc_update_bits(codec, SN95031_DMICMUX, 0x7, 0x07);

> > This looks like something which would more normally be done with
> > platform data than with writes in the machine driver.

> This is actually optional. The DMIC can be used as GPO or DMIC. This is user option.
> Wanted to explicitly code here as this machine DMICs are used.

I'm not saying it shouldn't be optional, I'm saying it should be passed
into the driver using platform data instead.