[alsa-devel] [PATCH 1/3] ASoC: WM8903: Add wm8903_set_gpio
broonie at opensource.wolfsonmicro.com
Wed Jan 19 01:21:02 CET 2011
On Tue, Jan 18, 2011 at 04:37:37PM -0700, Stephen Warren wrote:
> From: Stephen Warren <swarren at nvidia.com>
This should be implemented using gpiolib - see WM8962 for an example of
this. That way the control can be plugged into more other subsystems in
the kernel (probably including whenever I or someone else gets around to
it a widget like the one you open code in a later patch). I know some
of the drivers do export the GPIOs using custom APIs but that's
something that should be fixed.
> Also, fix platform_data handling to have an explicit "don't touch this pin"
This should've been a separate patch since it's OK to go in as-is.
> Temporarily hack out the mic detection platform_data handling for simplicity
There's no patch restoring the functionality...
> tesing the GPIO changes. Should the write-sequencer enabling be conditional?
Yes. It's not actually enabling the write sequencer itself, it's
enabling a low rate clock that's shared between a number of functions in
the device including jack detection. Without the clock jack detection
will not function.
More information about the Alsa-devel