[alsa-devel] [PATCH] ASoC: dapm: Fix race condition in widgets power list creation

Mark Brown broonie at opensource.wolfsonmicro.com
Tue Jan 18 13:26:05 CET 2011


On Tue, Jan 18, 2011 at 02:08:51PM +0200, Peter Ujfalusi wrote:
> On 01/18/11 13:39, ext Mark Brown wrote:

> > > I *suspect* that we're in a similar case and either the locking has been
> > > broken by the multi-component stuff or there's other cases that need
> > > protection, probably the jack detection code.

> The snd_soc_dapm_sync is just a wrapper for dapm_power_widgets, right?
> It (snd_soc_dapm_sync) is used in soc-core:soc_post_component_init.

You're jumping into the analysis mid-way here again...

> Modify the snd_soc_dapm_sync to use the codec->mutex around the
> dapm_power_widgets call.

This doesn't sound like the right solution in a multi-CODEC system, DAPM
will affect multiple devices within the system.


More information about the Alsa-devel mailing list