[alsa-devel] [PATCH] ASoC: WL1273 FM radio: Access I2C IO functions through pointers.

Mark Brown broonie at opensource.wolfsonmicro.com
Mon Jan 17 16:15:06 CET 2011

On Mon, Jan 17, 2011 at 04:58:14PM +0200, Matti J. Aaltonen wrote:
> On Mon, 2011-01-17 at 13:56 +0000, ext Mark Brown wrote:

> -       select SND_SOC_WL1273 if RADIO_WL1273
> +       select SND_SOC_WL1273
>         select SND_SOC_WM2000 if I2C
>         select SND_SOC_WM8350 if MFD_WM8350
>         select SND_SOC_WM8400 if MFD_WM8400

> That way the compilation of the codec would be independent of the rest
> of the driver...

Will the resulting code actually link if the MFD driver hasn't been
built?  Looks like it given that everything looks like hard coded
vtable dereferences and there's no API from the MFD driver to its users.
I'm really unsure what the MFD driver is supposed to do now, it'll only
ever instantiate a single subdevice and offers no services to users - it
seems better to just remove it, it looks like it's just creating
needless complication.

I have to say it looks like the locking at best a bit odd, some of the
APIs require that the CODEC driver lock a lock from the core by hand
while others have no locking in the interface.

More information about the Alsa-devel mailing list