[alsa-devel] [PATCH 4/4] ASoC: soc core allow machine driver to register the card

Koul, Vinod vinod.koul at intel.com
Fri Jan 14 14:52:03 CET 2011

> > > If that's all it is then the check should be changed to return -EINVAL
> > > or similar as this is an error which prevents the device being
> > > instantiated.  It shouldn't pretend it succeeded, and not doing so will
> > > save us having to check in any of the other functions.
> > Agreed, but on the other hand if someone is using register api they should
> > not be creating the device, so probe shouldn't be called at all.
> > We can leave this check. What do you think?
> I think the check should be changed to report an error since they should
> never be calling this function in the first place; this is the standard
> thing for devices with an invalid setup.
Yes, that's a better idea.
Sent you this patch updated.


More information about the Alsa-devel mailing list