[alsa-devel] [PATCH 4/4] ASoC: soc core allow machine driver to register the card

Mark Brown broonie at opensource.wolfsonmicro.com
Fri Jan 14 12:37:26 CET 2011

On Fri, Jan 14, 2011 at 04:55:47PM +0530, Koul, Vinod wrote:

> > If that's all it is then the check should be changed to return -EINVAL
> > or similar as this is an error which prevents the device being
> > instantiated.  It shouldn't pretend it succeeded, and not doing so will
> > save us having to check in any of the other functions.

> Agreed, but on the other hand if someone is using register api they should
> not be creating the device, so probe shouldn't be called at all.
> We can leave this check. What do you think?

I think the check should be changed to report an error since they should
never be calling this function in the first place; this is the standard
thing for devices with an invalid setup.

More information about the Alsa-devel mailing list