[alsa-devel] Fix section mismatch in wm8995.c
broonie at opensource.wolfsonmicro.com
Tue Jan 11 19:14:11 CET 2011
On Tue, Jan 11, 2011 at 06:48:30PM +0100, Takashi Iwai wrote:
> IMO, such a data should be uniquely handled -- either init-only or
> not. Through a quick look, snd_soc_cache_sync() may still refer to
> reg_cache_default. So, it's still risky to blindly set
> __devinitconst. (Yeah, I know it's not used right now, though ;)
That's a bug in the flat cache, it should be stashing a copy of it in
the codec instance. Though it only really makes a difference for
devices where you'd want to use a compressed cache anyway.
> That is, the data that shall be deleted shouldn't be kept in a
> structure that might be referred later from other places.
On the other hand you don't want to make stuff too much of a song and
dance to use.
More information about the Alsa-devel