[alsa-devel] Fix section mismatch in wm8995.c

Takashi Iwai tiwai at suse.de
Tue Jan 11 18:18:49 CET 2011


At Tue, 11 Jan 2011 17:10:22 +0000,
Mark Brown wrote:
> 
> On Tue, Jan 11, 2011 at 06:02:54PM +0100, Takashi Iwai wrote:
> 
> > I noticed the section mismatch in wm8995.c, and fixed now on topic/asoc
> > branch with the patch below.
> 
> Hrm, it'd be better to find some annotation for the pointer which lets
> us have the reference.  We at a higher level only dereference the
> pointer from the probe path, preventing the discard isn't a great
> solution.

Nah, that's way too complex for the time being.  I really prefer a
warning-less code for such a case.

The whole __init stuff have lots of potential improvements.  But,
improving it would cost pretty much.  And we don't want yet another
new annotation...


thanks,

Takashi


More information about the Alsa-devel mailing list