[alsa-devel] [PATCH] [v3] ASoC: cs4270: use the built-in register cache support

[Liam Girdwood]

On Mon, 2011-01-10 at 13:28 -0600, Timur Tabi wrote:
> Update the CS4270 driver to use ASoC's internal codec register cache feature.
> This change allows ASoC to perform the low-level I2C operations necessary to
> read the register cache.  Support is also added for initializing the register
> cache with an array of known power-on default values.
> 
> The CS4270 driver was handling the register cache itself, but somwhere along
> the conversion to multi-compaonent, this feature broke.
> 
> Signed-off-by: Timur Tabi <timur at freescale.com>

Acked-by: Liam Girdwood <lrg at slimlogic.co.uk>

> ---
> 
> Mark, I don't have power-management support working on my hardware, so I can't
> test cs4270_soc_resume(), but I have a suspicion that the call to
> i2c_smbus_write_byte_data() should be replaced with codec->hw_write().
> 

You may want to look at using snd_soc_cache_sync() to flush your cache
at resume().

Thanks

Liam

-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk