[alsa-devel] [PATCH] [v2] ASoC: cs4270: use the built-in register cache support

Mark Brown broonie at opensource.wolfsonmicro.com
Mon Jan 10 19:23:02 CET 2011

On Mon, Jan 10, 2011 at 11:35:50AM -0600, Timur Tabi wrote:

> This doesn't seem right to me.  Here, the .put function returns 0 or 1,
> depending on whether or not the bits were actually updated.  Is that what's
> intended?  I can't find any documentation that tells me what the return values
> of snd_kcontrol_put_t are supposed to be.

It's supposed to be 1 for change, 0 for no change or an error - if you
look at the core functions you'll see that they generally all follow
this idiom of using the return value from snd_soc_update_bits() directly.

More information about the Alsa-devel mailing list