[alsa-devel] [PATCH] ASoC: Taint the kernel if debugfs is used to write directly to CODECs

[Liam Girdwood]

On Thu, 2011-01-06 at 16:05 +0000, Mark Brown wrote:
> Since direct register writes may confuse the drivers and are supposed
> to be used only in diagnostic situations discourage their use in
> production by tainting the kernel when we do a write.
> 
> Signed-off-by: Mark Brown <broonie at opensource.wolfsonmciro.com>
> ---
>  sound/soc/soc-core.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
> index a233607..dbca5023 100644
> --- a/sound/soc/soc-core.c
> +++ b/sound/soc/soc-core.c
> @@ -209,6 +209,10 @@ static ssize_t codec_reg_write_file(struct file *file,
>  		start++;
>  	if (strict_strtoul(start, 16, &value))
>  		return -EINVAL;
> +
> +	/* Userspace has been fiddling around behind the kernel's back */
> +	add_taint(TAINT_USER);
> +
>  	snd_soc_write(codec, reg, value);
>  	return buf_size;
>  }

Acked-by: Liam Girdwood <lrg at slimlogic.co.uk>
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk