[alsa-devel] [PATCH 4/4] ASoC: SAMSUNG: Clean-up header includes

[Jassi Brar]

On Fri, Jan 7, 2011 at 1:57 PM, Seungwhan Youn <sw.youn at samsung.com> wrote:
> This patch remove including unnecessary/duplicated headers which relative
> with Samsung SoCs.
>
> Signed-off-by: Seungwhan Youn <sw.youn at samsung.com>
> ---
>  sound/soc/samsung/ac97.c                       |    8 +++-----
>  sound/soc/samsung/dma.c                        |   12 +++---------
>  sound/soc/samsung/goni_wm8994.c                |   10 +---------
>  sound/soc/samsung/h1940_uda1380.c              |   11 +----------
>  sound/soc/samsung/i2s.c                        |    7 +++----
>  sound/soc/samsung/jive_wm8750.c                |   11 -----------
>  sound/soc/samsung/ln2440sbc_alc650.c           |    6 ------
>  sound/soc/samsung/neo1973_gta02_wm8753.c       |   15 ++-------------
>  sound/soc/samsung/pcm.c                        |   15 +++------------
>  sound/soc/samsung/rx1950_uda1380.c             |   14 +-------------
>  sound/soc/samsung/s3c-i2s-v2.c                 |    7 +++----
>  sound/soc/samsung/s3c2412-i2s.c                |   16 +++-------------
>  sound/soc/samsung/s3c24xx-i2s.c                |   18 +++---------------
>  sound/soc/samsung/s3c24xx_simtec.c             |   12 ++----------
>  sound/soc/samsung/s3c24xx_simtec_hermes.c      |   10 ----------
>  sound/soc/samsung/s3c24xx_simtec_tlv320aic23.c |   12 ------------
>  sound/soc/samsung/s3c24xx_uda134x.c            |   12 ++----------
>  sound/soc/samsung/smartq_wm8987.c              |    9 +--------
>  sound/soc/samsung/smdk2443_wm9710.c            |    6 ------
>  sound/soc/samsung/smdk_spdif.c                 |    9 ++-------
>  sound/soc/samsung/smdk_wm8580.c                |    7 +------
>  sound/soc/samsung/smdk_wm9713.c                |    4 ----
>  sound/soc/samsung/spdif.c                      |    7 +++----
>  23 files changed, 37 insertions(+), 201 deletions(-)
>
> diff --git a/sound/soc/samsung/ac97.c b/sound/soc/samsung/ac97.c
> index 1e84ee0..18528d8 100644
> --- a/sound/soc/samsung/ac97.c
> +++ b/sound/soc/samsung/ac97.c
> @@ -12,16 +12,14 @@
>  * published by the Free Software Foundation.
>  */
>
> -#include <linux/init.h>
> -#include <linux/module.h>
> +#include <sound/soc.h>
> +
>  #include <linux/io.h>
>  #include <linux/delay.h>
>  #include <linux/clk.h>
>
> -#include <sound/soc.h>
> -
> -#include <plat/regs-ac97.h>
>  #include <mach/dma.h>
> +#include <plat/regs-ac97.h>
>  #include <plat/audio.h>

I think we'd better keep sound includes after linux's.
Same for all such instances in the remaining of the patch.
Otherwise, the patch is ok.

Thanks