[alsa-devel] [PATCH] ASoC: cs4270: fix dynamic initialization of register cache
broonie at opensource.wolfsonmicro.com
Thu Jan 6 23:04:06 CET 2011
On Thu, Jan 06, 2011 at 03:35:56PM -0600, Timur Tabi wrote:
> Mark Brown wrote:
> > If you're completely ignoring the standard cache and register I/O code
> > (which isn't ideal) then you should't be telling the core about your
> > cache.
> Tell that to the person who hacked up my driver and apparently broke it. I'm
> now playing catch-up. I need to learn all about this (new) register cache
> feature and then try to figure out how to make it work in my driver.
That'd be Liam in the multi-component conversion, though obviously that
didn't cause any immediate issues. The shared I/O code has been present
since mid 2009 though, including the cache management. This kind of
comes back to what I'm saying about making your code as idiomatic as
possible, the more a given piece of code diverges from standard idioms
the more likely it is that it will be unintentially broken by some other
FWIW using the standard stuff should just be a case providing defaults,
calling snd_soc_set_cache_io() and removing your custom I/O functions.
More information about the Alsa-devel