[alsa-devel] [PATCH 1/2] ASoC: soc-cache: Use reg_def_copy instead of reg_cache_default
timur at freescale.com
Thu Jan 6 17:26:43 CET 2011
Mark Brown wrote:
> So ask that question; "I looked at this and I'm not really sure if it's
> supposed to work or not - thing X suggests yes, thing Y suggests no but
> looks like a bug so..." and so on.
> In cases like this (although not I suspect this particular one) the
> answer is often that there was't any particular consideration for
> whatever unusual case you're looking at.
Ah, but I don't think my case is "unusual". Frankly, I think it's unusual to
hard-code default register values into a driver. I just don't see how you can
guarantee that the values will be correct for all supported revisions of the chip.
On the CS4270, for instance, one register contains the chip revision number.
There's no way I can know which revision will be used on any given board.
Anyway, I'll work on fixing this and post a patch.
Linux kernel developer at Freescale
More information about the Alsa-devel