[alsa-devel] [PATCH 1/2] ASoC: soc-cache: Use reg_def_copy instead of reg_cache_default

[Mark Brown]

On Wed, Jan 05, 2011 at 11:29:47PM +0000, Mark Brown wrote:

> > So are you saying that there's a bug in this patch?  Perhaps that code should
> > look like this:

> Perhaps it should, though my immediate question (without looking at the
> existing code again) is why the existing tests are being removed.

Having looked slightly further it does look like something I'd expect to
work.

More generally though what I'm trying to say is more about the approach
that's being taken here; with things like this it's generally much
better to at least have a dig into what's not working for you and have
an idea of what's going on rather than just stopping and asking.  This
is normally easier all round, either you'll be able to sort stuff out
yourself or you'll be able to ask a much better question.