[alsa-devel] [PATCH 3/4] ASoC sst: Add mid machine driver
broonie at opensource.wolfsonmicro.com
Mon Jan 3 17:28:26 CET 2011
On Mon, Jan 03, 2011 at 09:31:26PM +0530, Koul, Vinod wrote:
> > That helps but in that case you also need to remove all the device
> > registration stuff except for the actual machine driver from the init
> > and exit functions. The CPU stuff is all a fixed property of the CPU
> > and should be reigstered by the architecture code (possibly with some
> > control for the individual machine), the CODEC should be being
> > enumerated by whatever normally does that. The only thing this driver
> > should be doing is specifying how these things are connected.
> Yes, this patch had only the machine specific controls and dai link.
> It also creates the audio platform devices soc-audio platform and codec device.
> It doesn't do anything else
This is preceisely the problem. As I said the machine driver should
only be instantiating the machine driver. Actual physical devices
should be being instnantiated using the relevant buses.
Please look at how other platforms are doing this; you should be
following the same process.
> > What exactly is the msic CODEC? Given the references to non-specific
> > "vendor" registers it doesn't sound like a particular CODEC driver.
> Since Medfield platform is not declared yet we can't reveal the name of the
> codec vendor. The Moorestown codecs which we will add will not be nameless
> as this one and we will add as vendorversion.c format as in current codec
> drivers. I will replace this msic driver name once the platform is publically
So you're saying this is a driver for a specific device that you're
releasing under a code name? That's not what the code looks like.
None of this seems terribly clever for mainline; there's too many things
about these drivers don't look like what you'd expect embedded audio
drivers for Linux to look like from a 1000 foot level.
More information about the Alsa-devel