[alsa-devel] [PATCH 1/4] ASoC sst: Add msic codec driver

Koul, Vinod vinod.koul at intel.com
Mon Jan 3 16:36:56 CET 2011

> > > This looks mostly OK, but you probably want to run it through
> > > checkpatch.pl.  For quite a few of the debug prints you've got here
> > > you're replicating stuff that's in the core as standard - if you turn on
> > > debug logs from the core you should get equivalent logging.
> > Yes we have run checkpatch. Currently yes we have quite a few logs, we will
> There's quite a few places where there are coding style issues, in
> general if your code doesn't look like other kernel code that's a
> problem.  One of the most frequent issues was that you weren't using
> spaces around /* and */.
Checkpatch doesn't seem to catch these, have fixed them now.
Any other inconsistency you noted which may not be detected by checkpatch

> > remove them later when we add the capture, jack detection etc. It would be
> > nice to have these logs on.
> It would be good if you could at least make the logging consistent with
> the rest of the subsystem, and as I say avoid replicating logging which
> is already provided by the subsystem.  The point is not that this stuff
> exists, the point is that it's replicating a facility that's already
> there.
Agreed, I have removed the duplication of what is there already in soc-core


More information about the Alsa-devel mailing list