[alsa-devel] [PATCH 0/6] hdspmixer fixes
tiwai at suse.de
Mon Feb 28 15:41:27 CET 2011
At Mon, 28 Feb 2011 15:24:58 +0100,
Adrian Knoth wrote:
> On Mon, Feb 28, 2011 at 03:07:45PM +0100, Takashi Iwai wrote:
> > > > Though, the static definitions in channel_mapping.h aren't ideal.
> > > > If these are referred from difference places, they should be external
> > > > and defined only once.
> > >
> > > I'm not sure what you mean. Do you suggest to make them external inside
> > > hdspmixer? Like with pixmaps.h?
> > Yes.
> > The static array definitions shouldn't be included in multiple files.
> The patch was half ready when I noticed that the static arrays are only
> referenced exactly once in the whole code.
> I could complete the patch, though there seems to be no real benefit
> from it at the moment.
In that case, it's fine. Just remove other references in *.c files.
More information about the Alsa-devel