[alsa-devel] [PATCH 0/6] hdspmixer fixes

[Adrian Knoth]

On Mon, Feb 28, 2011 at 11:14:40AM +0100, Takashi Iwai wrote:

> > Also, the old code never handled three cards correctly, but that's
> > fixed, too. (and tested against the three RME cards currently in my
> > workstation)
> Thanks, applied now to alsa-tools git tree.

TNX.

> Though, the static definitions in channel_mapping.h aren't ideal.
> If these are referred from difference places, they should be external
> and defined only once.

I'm not sure what you mean. Do you suggest to make them external inside
hdspmixer? Like with pixmaps.h? Or are you contemplating to put them
somewhere else, let's say hdspm.h? (Uh, let's not say hdspm.h ;) )

> Currently, you'll get tons of compile warnings.
> Care to fix these?

Fixed now.


Cheers

-- 
mail: adi at thur.de  	http://adi.thur.de	PGP/GPG: key via keyserver