[alsa-devel] [PATCH v20 0/3] ASoC/MFD/V4L2: WL1273 FM Radio driver

Matti J. Aaltonen matti.j.aaltonen at nokia.com
Mon Feb 28 12:02:28 CET 2011


Hello.

And thanks for the comments. If we now move quickly enough we can
get this thing in before it becomes deprecated...

Samuel wrote:
> for Mauro to take this one you'd have to provide a
> diff against the already existing wl1273-core.

I've made these patches against the existing stuff.

>> + * Copyright (C) 2010 Nokia Corporation
>2011.

Changed.

>> +}
> I'm confused with this one: Isn't WL1273_VOLUME_SET a command ? Also,
> how can reading from it set the volume ?

It cannot... so I've changed it (back) to write.

>> +     i2c_set_clientdata(client, NULL)
>Not needed.

Removed.

>> +err:
>> +     i2c_set_clientdata(client, NULL);
>Ditto.

Ditto.

Cheers,
Matti

Matti J. Aaltonen (3):
  MFD: Wl1273 FM radio core: Add I2C IO functions.
  V4L2: Wl1273 FM Radio: Remove I2C IO functions.
  ASoC: WL1273 FM radio: Access I2C IO functions through pointers.

 drivers/media/radio/radio-wl1273.c |  360 +++++++++++-------------------------
 drivers/mfd/Kconfig                |    2 +-
 drivers/mfd/wl1273-core.c          |  149 +++++++++++++++-
 include/linux/mfd/wl1273-core.h    |    2 +
 sound/soc/codecs/Kconfig           |    2 +-
 sound/soc/codecs/wl1273.c          |   11 +-
 6 files changed, 264 insertions(+), 262 deletions(-)



More information about the Alsa-devel mailing list