[alsa-devel] [PATCH v4] ASoC: Add Freescale SGTL5000 codec support

Mark Brown broonie at opensource.wolfsonmicro.com
Mon Feb 21 19:47:33 CET 2011


On Mon, Feb 21, 2011 at 08:59:58AM -0600, Timur Tabi wrote:
> On Sun, Feb 20, 2011 at 6:09 PM,  <zhaoming.zeng at freescale.com> wrote:
> 
> > +#Freescale SGTL5000 codec
> > +config SND_SOC_SGTL5000
> > +       tristate
> > +

> I meant that you should add actual "help" text so that a person
> selecting this driver would know what it is.  Like this:

> config SND_SOC_SGTL5000
>    tristate "Freescale SGTL5000 audio codec"
>    help
>       Select this option to enable the Freescale SGTL5000 audio codec, etc etc

Not for mosts CODEC drivers, these should be selected by the machine
drivers which use them rather than enabled directly by users so they are
not expected to have help text, except in the unusual case that they're
set up for use with OpenFirmware without bindings.


More information about the Alsa-devel mailing list