[alsa-devel] [PATCH v2 08/13] OMAP2+: McBSP: hwmod adaptation for McBSP

[Tony Lindgren]

* ABRAHAM, KISHON VIJAY <kishon at ti.com> [110201 22:22]:
> On Tue, Feb 1, 2011 at 11:14 PM, Jarkko Nikula <jhnikula at gmail.com> wrote:
> > On Tue, 01 Feb 2011 14:22:49 +0200
> > Peter Ujfalusi <peter.ujfalusi at nokia.com> wrote:
> >
> >> Looks good, but...
> >> > +   if (oh->class->rev == MCBSP_CONFIG_TYPE3) {
> >> > +           if (id == 2)
> >> > +                   pdata->buffer_size = 0x500; /*FIFO size is 1024 + 256*/
> >> > +           else
> >> > +                   pdata->buffer_size = 0x80;  /*FIFO size is 128*/
> >> > +   }
> >>
> >> I would add spaces around these comments (after /* and before */).
> >>
> > Actually this part of code doesn't compile for CONFIG_ARCH_OMAP2 if
> > CONFIG_ARCH_OMAP3 is not set. Reason is that the buffer_size in under
> > CONFIG_ARCH_OMAP3 compilation in struct omap_mcbsp_platform_data
> > definition.
> >
> > I think it's easiest if this patch just removes that conditional
> > compilation from struct omap_mcbsp_platform_data as it really doesn't
> > save that much from non !OMAP3 builds.
> 
>   Thanks. Will fix it in the next version.

Any news on updating this series?

Note that you can now leave out the omap4 hwmod data as that has
been merged to omap-for-linus.

Regards,

Tony