[alsa-devel] [PATCH 1/3] ASoC: sn95031: Add jack support in the codec

Mark Brown broonie at opensource.wolfsonmicro.com
Wed Feb 9 13:11:39 CET 2011

On Wed, Feb 09, 2011 at 02:42:25PM +0530, Koul, Vinod wrote:

> +void disable_jack_btn(struct snd_soc_codec *codec)
> +{
> +	snd_soc_write(codec, SN95031_BTNCTRL2, 0x00);
> +}
> +EXPORT_SYMBOL_GPL(disable_jack_btn);

This needs to be namespaced.  It's also surprising that the matching
enable function isn't exposed...

The code itself looks OK.

More information about the Alsa-devel mailing list