[alsa-devel] [PATCH 6/7] ASoC: Samsung: neo1973_gta02: Fix bluetooth DAI registration

Mark Brown broonie at opensource.wolfsonmicro.com
Mon Feb 7 18:02:14 CET 2011

Please fix your MUA to word wrap at less than 80 columns, I've reflowed
your text so it's legible.

On Mon, Feb 07, 2011 at 05:53:56PM +0100, Lars-Peter Clausen wrote:

> > In any
> > case, we clearly shouldn't be applying patches which bodge around the
> > core.

> Well the alternative would be a patch looking like this:

> -	.cpu_dai_name = "bluetooth-dai",
> +	.cpu_dai_name = "soc-core",

> Which isn't really nice either.

If you think the core isn't behaving helpfully the core should be
changed.  This is part of how APIs evolve to be maximally useful.

To be honest it's not massively obvious that we shouldn't just be taking
the name of the device here, either using a device to represent the
modem or registering the card using snd_soc_register_machine() and using
a more meaningful name for the card seems like a sensible approach here.

More information about the Alsa-devel mailing list