[alsa-devel] [PATCH 3/6] ASoC: WM8903: Fix mic detection issues

Mark Brown broonie at opensource.wolfsonmicro.com
Thu Feb 3 23:38:01 CET 2011


On Thu, Feb 03, 2011 at 01:56:15PM -0700, Stephen Warren wrote:
> wm8903.h:
> * There is no hysteresis enable field in the current datasheet.
> * Mic detection threshold field is only 2 bits wide.
> 
> wm8903.c:
> * Mic detection HW should be enabled if SW wants either mic detection or
>   short detection, rather than only when it wants both.

Please don't combine unrelated changes into a single patch, especially
in cases like this where one is a bug fix and the other is essentially a
cosmetic fixup.


More information about the Alsa-devel mailing list