[alsa-devel] [PATCH] ASoC: Tegra: Harmony: Remove redundant !!

Liam Girdwood lrg at slimlogic.co.uk
Tue Feb 1 15:01:09 CET 2011


On Mon, 2011-01-31 at 11:00 -0700, Stephen Warren wrote:
> gpio_set_value* should accept logic values not just 0 or 1. The WM8903 GPIO
> driver has been fixed to work this way, so remove the redundant !!
> previously required when it didn't accept values >1.
> 
> Signed-off-by: Stephen Warren <swarren at nvidia.com>
> ---
>  sound/soc/tegra/harmony.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/soc/tegra/harmony.c b/sound/soc/tegra/harmony.c
> index d1faa63..11e2cb8 100644
> --- a/sound/soc/tegra/harmony.c
> +++ b/sound/soc/tegra/harmony.c
> @@ -132,7 +132,7 @@ static int harmony_event_int_spk(struct snd_soc_dapm_widget *w,
>  	struct harmony_audio_platform_data *pdata = harmony->pdata;
>  
>  	gpio_set_value_cansleep(pdata->gpio_spkr_en,
> -				!!SND_SOC_DAPM_EVENT_ON(event));
> +				SND_SOC_DAPM_EVENT_ON(event));
>  
>  	return 0;
>  }

Acked-by: Liam Girdwood <lrg at slimlogic.co.uk>
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk



More information about the Alsa-devel mailing list