[alsa-devel] [PATCH 2/5] ALSA: snd-usb: implement new endpoint streaming model

[Takashi Iwai]

At Tue, 20 Dec 2011 10:48:37 +0100,
Daniel Mack wrote:
> 
> In order to split changes properly, this patch only adds the new
> implementation but leaves the old one around, so the the driver doesn't
> change its behaviour. The switch to actually use the new code is
> submitted separately.
> 
> Signed-off-by: Daniel Mack <zonque at gmail.com>

One point I'm not sure about this implementation is the use of
tasklet.  The tasklet itself runs again in ep->lock, what's the
rationale for it?  In other words, can't it be a straight function
call?

I would understand if it were a workqueue and running in the
schedulable context.  But, I see no big merit of tasklet here.
(And tasklet is a candidate to be dropped sometime in future.)

Maybe I'm missing something behind it...


thanks,

Takashi