[alsa-devel] [PATCH v4 4/6] core: add API header and driver header files

Mark Brown broonie at opensource.wolfsonmicro.com
Tue Dec 13 13:51:35 CET 2011


On Tue, Dec 13, 2011 at 06:19:49PM +0530, Nallasellan, Singaravelan wrote:
> > +struct snd_compr_runtime {
> > +	snd_pcm_state_t state;
> > +	struct snd_compr_ops *ops;
> > +	void *buffer;

> Can we define buffer as char *?

Clearly we *can* but why would we want to do that for a pointer to
unstructured data?

> > +	size_t buffer_size;
> > +	size_t fragment_size;

> Can we define buffer_size and fragment_size as unsigned items? 
> Can we have negative size here?

Again, what is the advantage in doing this?


More information about the Alsa-devel mailing list