[alsa-devel] [PATCH v2 5/5] ASoC: WM8903: Add device tree binding

Mark Brown broonie at opensource.wolfsonmicro.com
Wed Dec 7 13:33:09 CET 2011

On Tue, Dec 06, 2011 at 10:22:24AM -0800, Stephen Warren wrote:

> Now, everything still works without this. Looking at the Linux OF code,
> it works by retrieving the compatible property, taking everything after
> the comma if present, and then creating an i2c_board_info with that
> type, which in this case is "wm8903" and matches wm8903.c's i2c_device_id
> table. See drivers/of/of_i2c.c:of_i2c_register_devices() and the call to
> base.c:of_modalias_node().

> So, the question is: Should I go back and add the of_match table, or
> is I2C intended to work without it perpetually? I notice that you added
> an of_match table for all the other WM codecs.

You can't go back and do anything now as the patches are merged, you
need to fix incrementally.  You should do this for completeness even if
currently we work without it.

More information about the Alsa-devel mailing list